Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CELE-39 Enhance REST API with filters #14

Merged
merged 7 commits into from
Jul 22, 2024
Merged

CELE-39 Enhance REST API with filters #14

merged 7 commits into from
Jul 22, 2024

Conversation

dvcorreia
Copy link
Member

Features

Is now possible to:

  • search cells
  • search cells in a set of datasets
  • request cells in a set of datasets

Change notes

Neuron schema changed.
It now contains a datasetIds string list containing each dataset to which the neuron belongs to.
Affected endpoints:

  • /api/datasets/{dataset}/neurons
  • /api/cells

Implementation notes

A request to any endpoint returning neuron data has an extra database query to annotate neurons with their respective datasets.
How this affect performance has still to be investigated (TODO).

@dvcorreia dvcorreia requested a review from aranega July 22, 2024 16:16
@dvcorreia dvcorreia self-assigned this Jul 22, 2024
@dvcorreia dvcorreia changed the base branch from main to develop July 22, 2024 16:16
@dvcorreia dvcorreia marked this pull request as ready for review July 22, 2024 17:17
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dvcorreia 🙏 Looks good to me! :)

@aranega aranega merged commit e2e9a73 into develop Jul 22, 2024
5 checks passed
@aranega aranega deleted the feature/CELE-39 branch July 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants