Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the dropdown to select the dataset to load/display #10

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

Salam-Dalloul
Copy link

@Salam-Dalloul Salam-Dalloul commented Jul 6, 2024

all requirements of CELE-63 CELE-64 have been pushed to this PR and here is the rest of the implementation

  • retrieve all the datasets loaded already from the context? if yes retrieve these to display them in the dropdown.
  • create a common Autocomplete component to be used in the compare dialog and the 3D viewer
  • retrieve all the neurones to replace the dummy data inside of the compare dialog
Screen.Recording.2024-07-06.at.9.08.51.PM.mov

@Salam-Dalloul Salam-Dalloul requested a review from aranega July 6, 2024 17:48
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Salam-Dalloul some icons are missing in the 3d viewer, even if the functionalities are not ready yet the icons should be implemented. Thanks

@Salam-Dalloul Salam-Dalloul requested a review from ddelpiano July 8, 2024 12:18
@afonsobspinto afonsobspinto marked this pull request as ready for review July 9, 2024 15:11
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thanks @Salam-Dalloul

@afonsobspinto afonsobspinto marked this pull request as draft July 16, 2024 14:12
@afonsobspinto afonsobspinto marked this pull request as ready for review July 16, 2024 14:29
@afonsobspinto afonsobspinto removed the request for review from ddelpiano July 17, 2024 16:02
@aranega aranega merged commit 13e3d32 into feature/CELE-32 Jul 17, 2024
4 checks passed
@aranega aranega deleted the feature/CELE-63 branch July 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants