Fix/tx builder fetcher logic #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it is practically impossible to build a transaction completely offline, because there is no API to provide script ref size for inputs. I have added this in the
txIntype, and added logic to get rid of the need for a fetcher. The current txBuilder will add any inputs with refScriptSize also to therefTxInso that the txBuilder correctly accounts for these script sizes when calculating fees. It is somewhat of a hacky fix, but will work until we figure out a better method.Affect components
@meshsdk/common@meshsdk/contract@meshsdk/core@meshsdk/core-csl@meshsdk/core-cst@meshsdk/provider@meshsdk/react@meshsdk/transaction@meshsdk/walletType of Change
Related Issues
Closes #374
Checklist
npm run test)npm run build)Additional context
Now offline transaction building requires an extra input for scriptRefSize, if there is no scriptRef at the input, please explicitly put 0 as scriptRefSize. If it is left undefined, it is assumed to be an incomplete input info, and will require a fetcher instance.