Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StakeButton] delegateStake when account active, otherwise registerStake #356

Merged

Conversation

chaincrucial
Copy link

@chaincrucial chaincrucial commented Nov 1, 2024

Summary

  1. Re-enables the original delegateStake function
  2. Brings it in sync with the registerAddress function (e.g. onDelgated logic)
  3. Restores conditional behavior to delegateStake for already active accounts, and registerAddress for non active accounts.

Affect components

  • @meshsdk/common
  • @meshsdk/contract
  • @meshsdk/core
  • @meshsdk/core-csl
  • @meshsdk/core-cst
  • @meshsdk/provider
  • @meshsdk/react
  • @meshsdk/transaction
  • @meshsdk/wallet
  • Mesh playground (i.e. https://meshjs.dev/)
  • Mesh CLI

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Related Issues

Closes #355

Checklist

  • My code is appropriately commented and includes relevant documentation, if necessary
  • I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • All new and existing tests pass (i.e. npm run test)
  • The build is pass (i.e. npm run build)
  • I've marked everything as pass, deeming "not necessary" where applicable, as this mostly re-enables existing logic and is documented and fixes a bug introduced when the code/logic was removed.
  • Existing tests are not passing, but that comes from the main branch. I do not observe any new test failures introduced from this branch.

Additional Information

N/A

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mesh-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 10:52pm

Copy link

vercel bot commented Nov 1, 2024

@TrevorBenson is attempting to deploy a commit to the MeshJS Team on Vercel.

A member of the Team first needs to authorize it.

@jinglescode jinglescode merged commit 515bcc3 into MeshJS:main Nov 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The StakeButton UI component attempts to register the account that are already registered
3 participants