Update typing for level during setup #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up daiquiri, daiquiri will work perfectly fine if you provide a valid string for log_level, e.g. "DEBUG", just as in the following example code:
However, typing tools such as mypy or pylance will complain, because the typing defined is that it must conform to the level being an
int
.Looking at the nested code, for logging, when setting the level it does the following check:
So in essence it does check that it is an int or a string that is a key in the dictionary _nameToLevel.
Proposing that we update the typing so that typing checking tools do not complain.