filter x2 instead of the original x because x2 has the correct column…

… names (renamed from x)
Merck · Jan 11, 2025 · 5214d91 · 5214d91
1 parent 9053f2c
commit 5214d91
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/R/as_gt.R b/R/as_gt.R
@@ -412,7 +412,7 @@ gsd_parts <- function(
     x = arrange(x2, Analysis),
     title = title, subtitle = subtitle,
     footnote = footnote %||% gsd_footnote(method, columns),
-    alpha = max(filter(x, Bound == bound[1])[[alpha_column]])
+    alpha = max(filter(x2, Bound == bound[1])[[alpha_column]])
   )
 }
 

diff --git a/tests/testthat/test-independent_as_gt.R b/tests/testthat/test-independent_as_gt.R
@@ -231,8 +231,7 @@ test_that("Snapshot test for gs_power_wlr summary as_gt with colname_spanner and
     as_gt(
       colname_spanner = "Cumulative probability to cross boundaries",
       colname_spannersub = c("under H1", "under H0")
-    ) %>%
-    suppressWarnings() # Can be removed after <https://github.com/Merck/gsDesign2/issues/339> is fixed
+    )
 
   local_edition(3)
   expect_snapshot_output(gt_to_latex(output))