Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example in vignettes for customize label in boxly #41

Merged
merged 4 commits into from
May 17, 2024

Conversation

wangchen46
Copy link
Collaborator

Add new .Rmd file "hover-libeler" int vignettes for examples on how to customize hovering label in boxly.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job, @wangchen46 ! The vignettes looks super great to me and tutor me about the label custom. As add-on, I only have 3 editorial comments.

vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
1. Title
2. For section of r code not evaluted, add {r,eval=FALSE}
3. Add more details for hover_var_outlier in prepare_boxly()
@nanxstats nanxstats changed the title DEVR-3354: Add example in vignettes for customize label in boxly Add example in vignettes for customize label in boxly May 16, 2024
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
vignettes/hover-label.Rmd Outdated Show resolved Hide resolved
1. Format all argument names as inline code using backticks.
2. Remove blank line required between headings and text before Example 3
3. Headings using sentence case
4. Remove link the functions manually
5. i.e. -> i.e.
6. Run styler to format code
7. \VignetteIndexEntry needs to be identical to title
@wangchen46 wangchen46 requested a review from nanxstats May 16, 2024 16:48
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I think we should merge.

@nanxstats nanxstats merged commit f585e7c into main May 17, 2024
8 checks passed
@nanxstats nanxstats deleted the DEVR-3354-control-layout branch May 17, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants