feat: detect class instantiation with NewExpression and type inference (

#47)

package.json

@@ -33,7 +33,6 @@
     "@commitlint/config-conventional": "19.4.1",
     "@eslint/js": "^9.9.1",
     "@types/eslint": "^9.6.1",
-    "@types/node": "^22.5.2",
     "@typescript-eslint/rule-tester": "8.12.2",
     "@vitest/coverage-v8": "^2.0.5",
     "cz-git": "1.10.1",

src/rules/runtime-compat.ts

@@ -1,4 +1,4 @@
-import type { Identifier } from 'estree'
+import { ESLintUtils } from '@typescript-eslint/utils'
 import data from 'runtime-compat-data'
 import type { RuleConfig } from '../types'
 import { compatErrorMessage } from '../utils/compatErrorMessage'
@@ -24,13 +24,15 @@ export const runtimeCompatRule = (filterRuntimes: data.RuntimeName[], ruleConfig
     },
     defaultOptions: [],
     create: (context) => {
+      const services = ESLintUtils.getParserServices(context)
+
       const unsupportedApis = filterSupportCompatData(
         mapCompatData(data),
         filterRuntimes,
         ruleConfig,
       )
 
-      const reportError = (node: Identifier, unsupportesApiId: string) => {
+      const reportError = <T>(node: T, unsupportesApiId: string) => {
         const apiInfo = unsupportedApis[unsupportesApiId]
         if (!apiInfo) return
         const message = compatErrorMessage(unsupportesApiId, apiInfo)
@@ -39,22 +41,12 @@ export const runtimeCompatRule = (filterRuntimes: data.RuntimeName[], ruleConfig
       }
 
       return {
-        TSInterfaceDeclaration: (node) => {
-          console.log(node)
-        },
-        Identifier: (identifierNode) => {
-          // Detect a class constructor
-          if (identifierNode.parent.type === 'NewExpression') {
-            const unsupportesApiId = JSON.stringify([identifierNode.name])
-            reportError(identifierNode, unsupportesApiId)
-          }
-          // Detect variable assignment from class
-          if (identifierNode.parent.type === 'VariableDeclarator') {
-            if (identifierNode.parent.init === identifierNode) {
-              const unsupportesApiId = JSON.stringify([identifierNode.name])
-              reportError(identifierNode, unsupportesApiId)
-            }
-          }
+        NewExpression: (node) => {
+          const type = services.getTypeAtLocation(node)
+          const checker = services.program.getTypeChecker()
+          const className = checker.typeToString(type)
+          const unsupportesApiId = JSON.stringify([className])
+          reportError(node, unsupportesApiId)
         },
       }
     },

tests/rules/runtimeCompatRule.integration.test.ts

@@ -3,7 +3,7 @@ import { runtimeCompatRule } from '../../src/rules/runtime-compat'
 import { ruleTester } from './setup'
 
 const filterRuntimes: RuntimeName[] = ['node']
-const cacheErrorMsg =
+const cacheInstantiationError =
   "'Cache' - Unsupported API in node.\nDocs - https://developer.mozilla.org/docs/Web/API/Cache"
 
 ruleTester.run(
@@ -13,37 +13,24 @@ ruleTester.run(
     experimental: false,
   }),
   {
-    valid: [
-      {
-        code: 'fetch("https://www.google.com")',
-      },
-    ],
+    valid: ['fetch("https://www.google.com")'],
     invalid: [
       {
         // Detect unsupported API constructor call.
         code: /*javascript*/ `
-            const a = new Cache()
-            let b = new Cache()
-            b = new Cache()
+            const _Cache = Cache
+            let cache = new _Cache()
+            cache.add("test.html")
           `,
-        errors: [
-          { message: cacheErrorMsg },
-          { message: cacheErrorMsg },
-          { message: cacheErrorMsg },
-        ],
+        errors: [{ message: cacheInstantiationError }],
       },
       {
         // Detect unsupported API variable assignment.
         code: /*javascript*/ `
-            const n = Cache
-            let b = new Cache
-            b = new Cache
+            const cache = new Cache()
+            cache.add("test.html")
           `,
-        errors: [
-          { message: cacheErrorMsg },
-          { message: cacheErrorMsg },
-          { message: cacheErrorMsg },
-        ],
+        errors: [{ message: cacheInstantiationError }],
       },
     ],
   },