Update roll command, added joinNumbers #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making it so you can do `!roll 2d6+10` and get `Bot: user rolled 12 from 2d6+10: (1, 1) + 10`
|
now with a test for the roll function @slugalisk shall i redo this without regex? or is this readable / strict enough? |
slugalisk
reviewed
Nov 6, 2023
commands.go
Outdated
| if strings.Contains(parts[1], "d") { | ||
| parts := strings.Split(parts[1], "d") | ||
| args = []string{parts[1], parts[0]} | ||
| if math.MaxInt64/numDice <= numSides || numDice > 100 { |
There was a problem hiding this comment.
math.MaxInt64/numDice <= numSides is meant to check whether or not this could cause integer overflow. we also need to factor in the modifier now
commands.go
Outdated
| if len(parts) < 2 { | ||
| return | ||
| // Define a regular expression to extract dice rolling information | ||
| regexPattern := `^!roll\s+(\d+)d(\d+)\s*([+\-]\s*\d+)?(.*?)$` |
There was a problem hiding this comment.
should also support rolls with an s
commands.go
Outdated
| } | ||
|
|
||
| var sum, _ = compute(m.Message) |
There was a problem hiding this comment.
edit: need to check error here and return without responding to invalid input
commands_test.go
Outdated
| @@ -20,3 +21,29 @@ func TestParseModifiers(t *testing.T) { | |||
| } | |||
| // fmt.Println(err.Error()) | |||
| } | |||
|
|
|||
| func TestCompute(t *testing.T) { | |||
commands.go
Outdated
| if !strings.HasPrefix(m.Message, "!roll") { | ||
| return | ||
| } | ||
| func compute(input string) (int, error) { |
There was a problem hiding this comment.
can we call this computeRoll or something more descriptive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making it so you can do
!roll 2d6+10and getBot: user rolled 12 from 2d6+10: (1, 1) + 10