Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.15.0 - default template according to business #56

Conversation

ZhaoYangyang0403
Copy link
Contributor

Default template according to business.

@yumiguan yumiguan requested a review from a team September 22, 2023 07:56
def default_template_check(template_path):
global autoissue_ready

if not template_path.exists():
Copy link
Member

@yumiguan yumiguan Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not template_path:
 ...
    return

@@ -24,6 +26,14 @@ def get_workspace():
return metadata_dir


def get_default_template_path():
bugit_workspace = application.config.get('bugit.workspace', '')
bugit_default_template = application.config.get('bugit.default_template', '')
Copy link
Member

@yumiguan yumiguan Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugit_default_template = application.config.get('bugit.default_template')
if not bugit_default_template:
    return

bugit_workspace = application.config.get('bugit.workspace')
if not bugit_workspace:
    return

return Path(bugit_workspace) / Path(bugit_default_template)

@@ -24,6 +26,18 @@
return metadata_dir


def get_default_template_path():

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
@yumiguan yumiguan merged commit 48b290e into Meituan-Dianping:master Sep 27, 2023
8 checks passed
@yumiguan yumiguan changed the title default template according to business v1.15.0 default template according to business Sep 27, 2023
@yumiguan yumiguan changed the title v1.15.0 default template according to business v1.15.0 - default template according to business Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants