Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid: Expose public info about DetailRow being expanded #5949

Conversation

tesar-tech
Copy link
Collaborator

Description

Closes #5947

This update exposes DataGridRowInfo.DetailRowExpanded, requiring several adjustments:

  • Renamed the original DataGridRowInfo:
    Changed to _DataGridRowInfo to reflect its private nature while retaining DataGridRowInfo as the publicly exposed name. Alternatives considered include RowInfo, DataGridRowInfoPublic, etc.

  • Introduced a new public DataGridRowInfo:
    This class now directly exposes DetailRowExpanded. And can be used in a future to expose more a different info.

  • Renamed HasDetailRow to DetailRowExpanded:
    As mentioned in the issue description. An alternative like DetailRowVisible is possible, given the existing DetailRowStartsVisible, but Expanded feels better. It might also be worth renaming DetailRowStartsVisible to DetailRowStartsExpanded for consistency..

  • Renamed GetRowInfo to GetRowInfoPrivate:
    This change allows GetRowInfo to be used as the public method.

Merged 1.7, as it required a sample and a functional gh action for testing.

@tesar-tech tesar-tech requested a review from stsrki January 22, 2025 13:38
@stsrki
Copy link
Collaborator

stsrki commented Jan 22, 2025

I think something is not right with the PR. Too many files is changed. Have you used the wrong target branch?

@tesar-tech
Copy link
Collaborator Author

I think something is not right with the PR. Too many files is changed. Have you used the wrong target branch?

That's because I merged the 1.7 to this branch, because I needed the code example.

If you merge 1.7 to master the extra code won't be part of this pr anymore.

@stsrki
Copy link
Collaborator

stsrki commented Jan 29, 2025

  • As mentioned in the issue description. An alternative like DetailRowVisible is possible, given the existing DetailRowStartsVisible, but Expanded feels better.

🤔DetailRowVisible is not a bad name.

@stsrki stsrki merged commit c016ea0 into master Jan 29, 2025
2 checks passed
@stsrki stsrki deleted the dev/DataGrid-add-API-that-tells-us-if-detail-row-is-expanded-or-present branch January 29, 2025 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid: add API that tells us if detail row is expanded or present
2 participants