-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: Expose public info about DetailRow being expanded #5949
DataGrid: Expose public info about DetailRow being expanded #5949
Conversation
…ataGrid-add-API-that-tells-us-if-detail-row-is-expanded-or-present
I think something is not right with the PR. Too many files is changed. Have you used the wrong target branch? |
That's because I merged the 1.7 to this branch, because I needed the code example. If you merge 1.7 to master the extra code won't be part of this pr anymore. |
…il-row-is-expanded-or-present
🤔 |
Description
Closes #5947
This update exposes
DataGridRowInfo.DetailRowExpanded
, requiring several adjustments:Renamed the original
DataGridRowInfo
:Changed to
_DataGridRowInfo
to reflect its private nature while retainingDataGridRowInfo
as the publicly exposed name. Alternatives considered includeRowInfo
,DataGridRowInfoPublic
, etc.Introduced a new public
DataGridRowInfo
:This class now directly exposes
DetailRowExpanded
. And can be used in a future to expose more a different info.Renamed
HasDetailRow
toDetailRowExpanded
:As mentioned in the issue description. An alternative like
DetailRowVisible
is possible, given the existingDetailRowStartsVisible
, butExpanded
feels better. It might also be worth renamingDetailRowStartsVisible
toDetailRowStartsExpanded
for consistency..Renamed
GetRowInfo
toGetRowInfoPrivate
:This change allows
GetRowInfo
to be used as the public method.Merged 1.7, as it required a sample and a functional gh action for testing.