-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSBreakpointModule: add document.readyState checks #5495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, see comment for making sure the event is effectively attached? Also were you able to reproduce the issue? Or just trying to make the code more resilient?
@David-Moreira can you take care of this PR? |
PS. I will rebase it to 1.6. |
Wasn't this ready? What exactly do you want me to do here? |
I thought that you could finish the task. You had some comments previously about module loading and ready states, so maybe you could do it better. |
PS. 1.7 sounds good to me. |
@stsrki Anyway:
|
Closes #5482