[#41] [FEATURE] 반찬의 이미지 URL을 이미지 엔티티로 분리 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiwonKKang
reviewed
Aug 30, 2024
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishService.java
Outdated
Show resolved
Hide resolved
| return DishAndImage.of(dish, image); | ||
| } | ||
|
|
||
| public List<DishAndImage> searchDishes(TargetDishStore targetDishStore, String keyword) { |
There was a problem hiding this comment.
이거도 그렇게 readDishs()도 그렇게 targetDishStore를 파라미터로 받고있는데
저희가 반찬가게별로 반찬을 조회하는게 아니지않나요?
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishService.java
Outdated
Show resolved
Hide resolved
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishImageReader.java
Outdated
Show resolved
Hide resolved
infra/src/main/java/core/startup/mealtoktok/infra/dishstore/repository/CoreDishRepository.java
Show resolved
Hide resolved
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishAndImage.java
Show resolved
Hide resolved
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishAndImage.java
Show resolved
Hide resolved
domain/src/main/java/core/startup/mealtoktok/domain/dishstore/DishService.java
Outdated
Show resolved
Hide resolved
|
그리고 제가 좀더 살펴봤는데 isSoldOut 컬럼이 아니라 DishState 라는 Enum 클래스를 만들고 이 클래스로 Dish의 상태를 관리하는게 좋을거같아요! State 관련 도메인 로직은 저의 Order 또는 MealDelivery 한번 참고해주세요 그리고 따로 Dish의 수량(quantiy)를 관리해줘야할거같다는 생각이 들어요 주문 할때마다 quantity가 줄어들고 0이되면 state가 SOLD_OUT으로 바뀌는거죠 주문할떄마다 수량이 줄어드는 로직은 제가 구현할게요 Dish 도메인만 손봐주세요! |
JiwonKKang
reviewed
Aug 31, 2024
| @@ -48,7 +50,7 @@ private void checkMealNameExistsExcludingTarget(Meal meal, String mealName) { | |||
| private void checkDishSoldOut(List<Long> dishIds) { | |||
There was a problem hiding this comment.
도시락을 만들때 품절이라고 예외를 내보내면 안될거같아요
이미 만들어높은 도시락중에 품절이 생길수도있고 품절된 상품이있다고 도시락을 만들지 못하는건 안될거같아요
예외는 주문할때 던지면 충분할거같아요!
|
고생하셧어요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
✅ PR Point