Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#25] [Feature] 반찬가게 API 구현 #27

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Conversation

somln
Copy link
Contributor

@somln somln commented Aug 8, 2024

✨ 구현 기능 명세

  • 반찬가게 생성 / 조회 / 삭제 / 수정

✅ PR Point

AddressWithCoordinate맞게 사용한건 지 좀 확인해주세용

😭 어려웠던 점

@somln somln requested a review from JiwonKKang August 8, 2024 08:53
@somln somln linked an issue Aug 8, 2024 that may be closed by this pull request
2 tasks
import core.startup.mealtoktok.domain.user.Address;
import core.startup.mealtoktok.domain.user.AddressWithCoordinate;

public record DishStoreInfo(
Copy link
Contributor

@JiwonKKang JiwonKKang Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DishStore의 내용들을 DishStoreInfo로 래핑하셔서 DishStore에서 이 DTO를 사용하셔도 될꺼같아요
이거만 고치시고 merge하시면 될거같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 감사합니다~~

@somln somln merged commit 672c2cd into develop Aug 11, 2024
1 check passed
@somln somln deleted the feature/crud-dishstore branch August 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 반찬 가게 CRUD 구현
2 participants