Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create COMP 345 description. #262

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Create COMP 345 description. #262

merged 2 commits into from
Jan 3, 2024

Conversation

kpraays
Copy link
Contributor

@kpraays kpraays commented Jan 3, 2024

Transferred the content from the course description doc to COMP 345 page.

@sivareddyg
Copy link
Member

Thanks! Can you make this look as close as possible to https://github.com/McGill-NLP/mcgill-nlp.github.io/edit/main/_posts/teaching/2024-01-01-comp545-ling782-484-W24.md since some of the actions and template requires some metadata.

@sivareddyg sivareddyg merged commit 21e8122 into McGill-NLP:main Jan 3, 2024
1 check passed
@kpraays
Copy link
Contributor Author

kpraays commented Jan 3, 2024

Can you make this look as close as possible to https://github.com/McGill-NLP/mcgill-nlp.github.io/edit/main/_posts/teaching/2024-01-01-comp545-ling782-484-W24.md since some of the actions and template requires some metadata.? --> done

Have kept the same list for topics as in the doc.

@sivareddyg
Copy link
Member

Table of contents look broken.
Screenshot 2024-01-03 at 5 17 38 PM

Live here https://mcgill-nlp.github.io/teaching/comp345-ling345-W24/

Please fix.

@sivareddyg sivareddyg assigned sivareddyg and kpraays and unassigned sivareddyg Jan 3, 2024
@sivareddyg
Copy link
Member

Also, this stuff should appear

Screenshot 2024-01-03 at 5 19 58 PM

@kpraays
Copy link
Contributor Author

kpraays commented Jan 3, 2024

Created a new pr with the changes requested. Added the remaining part and converted all heading to h1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants