add tls13 client dummy state handlers and improve dispatch test #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhaoth
commented
Sep 14, 2021
yuhaoth
added
component-tls13
needs-review
gilles-peskine-arm
requested review from
gilles-peskine-arm
and removed request for
mpg
yuhaoth
force-pushed
the
pr/add-tls13-client-dummy-state-handlers
branch
5 times, most recently
from
227a321
to
59352da
Compare
ronald-cron-arm
requested changes
Sep 21, 2021
yuhaoth
commented
Sep 22, 2021
yuhaoth
force-pushed
the
pr/add-tls13-client-dummy-state-handlers
branch
4 times, most recently
from
8f6329c
to
56f9b87
Compare
xkqian
reviewed
Sep 23, 2021
yuhaoth
force-pushed
the
pr/add-tls13-client-dummy-state-handlers
branch
2 times, most recently
from
ef76e5e
to
311716b
Compare
|
Only Travis CI raise random fail . |
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Jerry Yu <[email protected]>
It is temporary check. If any change on `mbedtls_ssl_states`, please double check those tests Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Jerry Yu <[email protected]>
yuhaoth
force-pushed
the
pr/add-tls13-client-dummy-state-handlers
branch
from
dce27af
to
e86cd65
Compare
|
Rebased |
mpg
previously approved these changes
Sep 27, 2021
|
|
Signed-off-by: Jerry Yu <[email protected]>
ronald-cron-arm
requested changes
Sep 28, 2021
Signed-off-by: Jerry Yu <[email protected]>
ronald-cron-arm
approved these changes
Sep 28, 2021
ronald-cron-arm
added
needs-review
mpg
added
approved
|
I've checked that the feedback from Gilles either has been addressed, or is no longer relevant for this PR ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes two small changes
Improve TLS1.3 dispatch test
The test is to confirm client/server call correct handshake function. Originally, it depends on the return value, this PR adds two debug output message for client and server. And check if the message exists.
Add dummy handler functions for client states. I am not very sure if it is valuable
This PR adds all states and handlers needed by
MVP. The states are come from Fix compile errors without 0-RTT, MPS and compatible mode hannestschofenig/mbedtls#359, that PR disable options unneeded byMVP.I think this PR can reduce conflicts in future and make sure we did not miss anything.
All PR will change
mbedtls_ssl_tls13_handshake_client_step. So I create them with dummy handlers, future PRs can fill the dummy handlers to reduce conflicts. And if all handlers are filled, that means everything done and a real test forMVPshould be added.Difference with
prototype:ssl_tls13_client.cfor all states.prototypedid not create local functions, some functions are not inssl_tls13_client.cssl_tls13_<direction><state_name>directionvalues:read_, if the state depends on server input dataprocess_, base on add tls13 client dummy state handlers and improve dispatch test #4942 (comment) ,read_is replaced.write_, if the state will output data to server_, if it does not send/receive any datastate_name: the lowercase of state name without prefixStatus
READY