Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS1.3:ServerHello:Add parse server hello function #4919

Merged
merged 23 commits into from
Oct 27, 2021
Merged

TLS1.3:ServerHello:Add parse server hello function #4919

merged 23 commits into from
Oct 27, 2021

Conversation

yuhaoth
Copy link
Contributor

@yuhaoth yuhaoth commented Sep 5, 2021 •
edited
Loading

Add functions before post process

depends on #4918 and #4891

@yuhaoth yuhaoth linked an issue Sep 5, 2021 that may be closed by this pull request
Upstream TLS 1.3 ServerHello parsing state, ephemeral-only exchanges #4563
Closed
@yuhaoth yuhaoth added needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-work labels Sep 5, 2021
@yuhaoth yuhaoth force-pushed the pr/add-tls13-server-hello-parser branch 8 times, most recently from 7b8fdc7 to c6dc9a3 Compare September 10, 2021 09:06
@yuhaoth yuhaoth changed the title TLS1.3:ServerHello:Add parse function TLS1.3:ServerHello:Add parse server hello function Sep 10, 2021
@yuhaoth yuhaoth force-pushed the pr/add-tls13-server-hello-parser branch 2 times, most recently from 8770a7b to 5a53ef8 Compare September 11, 2021 02:28
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
yuhaoth
yuhaoth commented Sep 11, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
@yuhaoth yuhaoth force-pushed the pr/add-tls13-server-hello-parser branch 2 times, most recently from e22de52 to 63e6e92 Compare September 12, 2021 12:22
@yuhaoth yuhaoth mentioned this pull request Sep 14, 2021
Merged
@yuhaoth yuhaoth force-pushed the pr/add-tls13-server-hello-parser branch from 091b636 to 188468b Compare October 25, 2021 02:49
@yuhaoth
Copy link
Contributor Author

yuhaoth commented Oct 25, 2021 •
edited
Loading

Rebased.

xkqian
xkqian reviewed Oct 25, 2021
View reviewed changes
library/ssl_tls13_keys.c Show resolved Hide resolved
library/ssl_misc.h Show resolved Hide resolved
library/ssl_misc.h Show resolved Hide resolved
library/ssl_misc.h Show resolved Hide resolved
library/ssl_tls13_keys.c
return( ret );
}

ret = mbedtls_ssl_tls1_3_derive_handshake_secrets( md_type,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbedtls_ssl_tls13_derive_handshake_secrets()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer do not change it here.

ronald-cron-arm
ronald-cron-arm requested changes Oct 25, 2021
View reviewed changes
library/ssl_tls13_client.c Outdated Show resolved Hide resolved
library/ssl_tls13_keys.c Outdated Show resolved Hide resolved
ronald-cron-arm
ronald-cron-arm approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm
Copy link
Contributor

@paul-elliott-arm are you ok with the last version ?

@yuhaoth yuhaoth added needs-review Every commit must be reviewed by at least two team members, and removed needs-review Every commit must be reviewed by at least two team members, labels Oct 27, 2021
paul-elliott-arm
paul-elliott-arm approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final version LGTM

@paul-elliott-arm paul-elliott-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Oct 27, 2021
@ronald-cron-arm ronald-cron-arm merged commit 5893246 into Mbed-TLS:development Oct 27, 2021
@yuhaoth yuhaoth deleted the pr/add-tls13-server-hello-parser branch December 6, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xkqian xkqian xkqian left review comments

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-tls13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream TLS 1.3 ServerHello parsing state, ephemeral-only exchanges
4 participants
@yuhaoth @ronald-cron-arm @xkqian @paul-elliott-arm