Skip to content

Commit

Permalink
Further Python 3.7 removal cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
MatthiasValvekens committed Nov 19, 2023
1 parent 2912a5b commit a84a865
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
4 changes: 0 additions & 4 deletions pyhanko/sign/validation/report/tools.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
"""
ETSI TS 119 102-2 reporting functionality.
.. info:
This module requires optional ``[etsi]`` dependency group,
and only works on Python 3.8+ for dependency reasons.
.. warning::
This feature is incubating and subject to API changes.
"""
Expand Down
9 changes: 0 additions & 9 deletions pyhanko_tests/test_ades_validation_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@
from .test_ades_validation import DEFAULT_SIG_VALIDATION_SPEC
from .test_pades import PADES

py38_only = pytest.mark.skipif(
sys.version_info < (3, 8), reason="validation reports require python 3.8+"
)


async def _generate_basic_report(requests_mock, out):
with freeze_time('2020-11-25'):
Expand All @@ -56,7 +52,6 @@ async def _generate_basic_report(requests_mock, out):


@pytest.mark.asyncio
@py38_only
async def test_pades_basic_report_smoke_test(requests_mock):
with freeze_time('2020-11-20'):
w = IncrementalPdfFileWriter(BytesIO(MINIMAL_ONE_FIELD))
Expand All @@ -71,7 +66,6 @@ async def test_pades_basic_report_smoke_test(requests_mock):


@pytest.mark.asyncio
@py38_only
async def test_pades_basic_failing_report_smoke_test(requests_mock):
with freeze_time('2020-11-20'):
w = IncrementalPdfFileWriter(BytesIO(MINIMAL_ONE_FIELD))
Expand All @@ -89,7 +83,6 @@ async def test_pades_basic_failing_report_smoke_test(requests_mock):


@pytest.mark.asyncio
@py38_only
async def test_pades_basic_indeteriminate_report_smoke_test(requests_mock):
with freeze_time('2020-11-20'):
w = IncrementalPdfFileWriter(BytesIO(MINIMAL_ONE_FIELD))
Expand Down Expand Up @@ -122,7 +115,6 @@ async def _generate_lta_report(


@pytest.mark.asyncio
@py38_only
async def test_pades_lta_report_smoke_test(requests_mock):
with freeze_time('2020-11-20'):
w = IncrementalPdfFileWriter(BytesIO(MINIMAL_ONE_FIELD))
Expand All @@ -143,7 +135,6 @@ async def test_pades_lta_report_smoke_test(requests_mock):


@pytest.mark.asyncio
@py38_only
async def test_pades_with_attributes_report_smoke_test(requests_mock):
pki_arch = CERTOMANCER.get_pki_arch(ArchLabel('testing-ca-with-aa'))

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ testing-basic = [
]
testing = [
"pyHanko[testing-basic,pkcs11,xmp,opentype,image-support,async-http,extra-pubkey-algs]",
"pyHanko[etsi];python_version>=\"3.8\"",
"pyHanko[etsi]",
"pytest-aiohttp~=1.0.4",
"certomancer-csc-dummy==0.2.3",
]
Expand Down

0 comments on commit a84a865

Please sign in to comment.