Bump artifact actions to v4

MatthiasValvekens · Dec 18, 2023 · 3d3f60f · 3d3f60f
1 parent 6d7b0d3
commit 3d3f60f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/build-pipeline.yml b/.github/workflows/build-pipeline.yml
@@ -42,7 +42,7 @@ jobs:
         id: artifact-hashes
         run: cd dist && echo "hashes=$(sha256sum * | base64 -w0)" >> "$GITHUB_OUTPUT"
       - name: Upload dist artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pyhanko-dist
           path: dist/
@@ -59,7 +59,7 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
       - name: Download dist artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pyhanko-dist
           path: dist/
@@ -69,9 +69,9 @@ jobs:
         env:
           PKCS11_TEST_MODULE: ${{ env.SOFTHSM2_MODULE_PATH }}
       - name: Stash coverage report
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage
+          name: coverage-${{ strategy.job-index }}
           path: "*-coverage.xml"
   live-integration-tests:
     runs-on: ubuntu-latest
@@ -86,7 +86,7 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
       - name: Download dist artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pyhanko-dist
           path: dist/
@@ -109,9 +109,9 @@ jobs:
           LIVE_CERTOMANCER_HOST_URL: http://localhost:9000
           LIVE_CSC_SCAL2_HOST_URL: http://localhost:8999
       - name: Stash coverage report
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage
+          name: coverage-live-${{ strategy.job-index }}
           path: "*-coverage.xml"
   smoke-tests:
     runs-on: ubuntu-latest
@@ -123,7 +123,7 @@ jobs:
         with:
           python-version: ${{ env.MAIN_PYTHON_VERSION }}
       - name: Download dist artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pyhanko-dist
           path: dist/
@@ -144,9 +144,9 @@ jobs:
       # checkout necessary to ensure the uploaded report contains the correct paths
       - uses: actions/checkout@v4
       - name: Retrieve coverage reports
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: coverage
+          pattern: coverage-*
           path: ./reports/
       - name: Upload all coverage reports to Codecov
         uses: codecov/codecov-action@v3

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -52,7 +52,7 @@ jobs:
         env:
           VERSION: ${{ steps.getversion.outputs.version }}
       - name: Upload release body
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: release-body
           path: release.md
@@ -81,17 +81,17 @@ jobs:
       discussions: write
     steps:
     - name: Download dist artifacts
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: pyhanko-dist
         path: dist/
     - name: Download provenance data
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: multiple.intoto.jsonl
         path: provenance/
     - name: Download release body
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: release-body
         path: release-body