Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve message for missing keys #49

Merged
merged 3 commits into from
Oct 9, 2024
Merged

improve message for missing keys #49

merged 3 commits into from
Oct 9, 2024

Conversation

gpetretto
Copy link
Contributor

Closes #48.
Provide a clearer error message, suggesting a possible alternative for the wrong template field and pointing to the actual location of the template.

davidwaroquiers
davidwaroquiers approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All good to me! Just three small comments but more like "I'm perfectly ok with how it is now, you can decide to do what I propose in the comment" ;-)

src/qtoolkit/io/base.py Outdated Show resolved Hide resolved
src/qtoolkit/io/base.py Outdated Show resolved Hide resolved
tests/io/test_base.py Outdated Show resolved Hide resolved
@gpetretto gpetretto merged commit c54b383 into Matgenix:develop Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwaroquiers davidwaroquiers davidwaroquiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing SLURM template variables
2 participants
@gpetretto @davidwaroquiers