Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate usage of field_validator to pydantic v2 #38

Closed
wants to merge 2 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 18, 2023

Hi @gpetretto, just been testing the state of the original pydantic v2 PR and found I had to add this to get my configs to load without issue.

@gpetretto
Copy link
Contributor

Hi, sorry, I actually also encountered this issue and fixed this in #37. I was hoping to get it merged at this point and did not backport the fix to the pydantic2 branch. Merging this should not be an issue anyway, since it will be an easy conflict to merge.

@ml-evs
Copy link
Member Author

ml-evs commented Dec 20, 2023

Superseded by #29 and #37

@ml-evs ml-evs closed this Dec 20, 2023
@ml-evs ml-evs deleted the ml-evs/pydantic2 branch December 20, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants