Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize gui implementation #243

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Finalize gui implementation #243

merged 3 commits into from
Jan 17, 2025

Conversation

gpetretto
Copy link
Contributor

Few updates for the GUI, with the option to start it from the CLI.

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. Just maybe one suggestion for the doc of the gui.

doc/source/user/gui.rst Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (b0671c0) to head (ef8056d).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/jobflow_remote/webgui/webgui.py 0.00% 19 Missing ⚠️
src/jobflow_remote/cli/gui.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
- Coverage    71.32%   71.15%   -0.18%     
===========================================
  Files           49       50       +1     
  Lines         6703     6728      +25     
  Branches      1081     1081              
===========================================
+ Hits          4781     4787       +6     
- Misses        1557     1576      +19     
  Partials       365      365              
Files with missing lines Coverage Δ
src/jobflow_remote/cli/__init__.py 100.00% <100.00%> (ø)
src/jobflow_remote/jobs/jobcontroller.py 80.00% <ø> (ø)
src/jobflow_remote/cli/gui.py 71.42% <71.42%> (ø)
src/jobflow_remote/webgui/webgui.py 0.00% <0.00%> (ø)

@fraricci
Copy link
Collaborator

Thanks Guido. It's working fine on my end. Nothing to add/change at the moment.

@gpetretto gpetretto merged commit 8a78800 into develop Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants