Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching off daemon if no running runner doc #240

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

gpetretto
Copy link
Contributor

Fixing a potential issue for the upgrade procedure, signaled in #211 (comment)
Now it is possible to stop the runner even if there is no running_runner document.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.32%. Comparing base (1add6b9) to head (984e395).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
+ Coverage    71.15%   71.32%   +0.17%     
===========================================
  Files           49       49              
  Lines         6677     6703      +26     
  Branches      1074     1081       +7     
===========================================
+ Hits          4751     4781      +30     
+ Misses        1559     1557       -2     
+ Partials       367      365       -2     
Files with missing lines Coverage Δ
src/jobflow_remote/cli/runner.py 69.27% <100.00%> (+4.37%) ⬆️
src/jobflow_remote/config/base.py 83.47% <100.00%> (+0.07%) ⬆️
src/jobflow_remote/jobs/daemon.py 68.50% <100.00%> (+0.60%) ⬆️
src/jobflow_remote/jobs/jobcontroller.py 80.00% <100.00%> (+0.05%) ⬆️
src/jobflow_remote/jobs/runner.py 77.61% <100.00%> (+0.21%) ⬆️

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. Just, do we need a test here ?

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me! Just 2 typos.

tests/db/jobs/test_daemon.py Outdated Show resolved Hide resolved
tests/db/jobs/test_daemon.py Outdated Show resolved Hide resolved
@gpetretto gpetretto merged commit 07918ed into develop Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants