-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switching off daemon if no running runner doc #240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
+ Coverage 71.15% 71.32% +0.17%
===========================================
Files 49 49
Lines 6677 6703 +26
Branches 1074 1081 +7
===========================================
+ Hits 4751 4781 +30
+ Misses 1559 1557 -2
+ Partials 367 365 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me. Just, do we need a test here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me! Just 2 typos.
55d0ce3
to
984e395
Compare
Fixing a potential issue for the upgrade procedure, signaled in #211 (comment)
Now it is possible to stop the runner even if there is no running_runner document.