-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various updates #234
Merged
Merged
Various updates #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
+ Coverage 73.15% 73.61% +0.45%
===========================================
Files 48 48
Lines 6348 6454 +106
Branches 1013 1039 +26
===========================================
+ Hits 4644 4751 +107
+ Misses 1342 1336 -6
- Partials 362 367 +5
|
davidwaroquiers
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. All good to me!
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates addressing previously discussed issues.
remote_job_data.json
file is missing from the run folder this usually generates an unclear error message (as discussed in Jobs fail with errorRemote error: file path/to/job_dir/remote_job_data.json for job xxx does not exist
#157. If this is missing, allow to complete the download step and raise an error during the completion. This should allow to often provide better error messages if they are included in the jfremote_out.json.jf job info
with the-v
option. This partially addresses Better error handling forpre_run
#220. More updates for the CI in an upcoming PR.--locked
for the list of flowsFlow.metadata
. Closing How to add metadata toflows
docs? #124