Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #234

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Various updates #234

merged 13 commits into from
Jan 13, 2025

Conversation

gpetretto
Copy link
Contributor

Several updates addressing previously discussed issues.

  • Allow to specify a delay between the end of a job on the worker and the start of a download. Closing Optionally delay download after job end #210
  • If the remote_job_data.json file is missing from the run folder this usually generates an unclear error message (as discussed in Jobs fail with error Remote error: file path/to/job_dir/remote_job_data.json for job xxx does not exist #157. If this is missing, allow to complete the download step and raise an error during the completion. This should allow to often provide better error messages if they are included in the jfremote_out.json.
  • To better show the error queue.out and queue.err are also downloaded and stored in the DB. Cut if they are too long and only showed in jf job info with the -v option. This partially addresses Better error handling for pre_run #220. More updates for the CI in an upcoming PR.
  • Improve the upgrade procedure to handle development version. Also making the option to set the target version visibile. Closing An Error occurred during the command execution: ValueError No daemon runner document. #211
  • Option --locked for the list of flows
  • Actually handle the newly introduced Flow.metadata. Closing How to add metadata to flows docs? #124
  • fix the handling of weeks interval in reports. There were inconsitent results depending on the day of the week and year the report was generated. Also unexpected causing test failures.
  • Don't check the MAC address when checking the running runner in the DB. The code could give different values for the same machine (if multiple network devices are present), or different result if a virtual machine with the same hostname is switched on and off.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.61%. Comparing base (01ffa70) to head (8aef1f8).

Files with missing lines Patch % Lines
src/jobflow_remote/jobs/runner.py 77.27% 3 Missing and 2 partials ⚠️
src/jobflow_remote/cli/formatting.py 55.55% 2 Missing and 2 partials ⚠️
src/jobflow_remote/jobs/jobcontroller.py 95.83% 2 Missing and 1 partial ⚠️
src/jobflow_remote/remote/data.py 77.77% 2 Missing ⚠️
src/jobflow_remote/cli/admin.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
+ Coverage    73.15%   73.61%   +0.45%     
===========================================
  Files           48       48              
  Lines         6348     6454     +106     
  Branches      1013     1039      +26     
===========================================
+ Hits          4644     4751     +107     
+ Misses        1342     1336       -6     
- Partials       362      367       +5     
Files with missing lines Coverage Δ
src/jobflow_remote/cli/flow.py 70.00% <ø> (ø)
src/jobflow_remote/cli/types.py 100.00% <100.00%> (ø)
src/jobflow_remote/config/base.py 83.40% <100.00%> (+0.07%) ⬆️
src/jobflow_remote/jobs/daemon.py 67.89% <ø> (ø)
src/jobflow_remote/jobs/data.py 89.08% <100.00%> (+0.09%) ⬆️
src/jobflow_remote/jobs/run.py 42.30% <ø> (ø)
src/jobflow_remote/jobs/upgrade.py 88.17% <100.00%> (+0.25%) ⬆️
src/jobflow_remote/cli/admin.py 88.48% <90.00%> (+0.61%) ⬆️
src/jobflow_remote/remote/data.py 53.73% <77.77%> (+0.83%) ⬆️
src/jobflow_remote/jobs/jobcontroller.py 79.94% <95.83%> (+1.26%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. All good to me!

src/jobflow_remote/jobs/jobcontroller.py Show resolved Hide resolved
src/jobflow_remote/jobs/jobcontroller.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants