Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement migrate:fresh #861

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

eaguad1337
Copy link
Member

Implements #860

I tested it on MySQL, SQLite and Postgres because I had problems running tests. Hopefully you can help me with this tests @josephmancuso

@josephmancuso
Copy link
Member

i just spent a good amount of time trying to get this to work ecause my tables all had foreign key constraints with eachother

@eaguad1337
Copy link
Member Author

i just spent a good amount of time trying to get this to work ecause my tables all had foreign key constraints with eachother

I added a ignore_fk param and I realized that Postgres fails when trying to use enable_foreign_key_constraints because this method is not implemented. I returned true if sql is None. Let me know if makes sense to you.

@josephmancuso
Copy link
Member

hmm now these tests are failing

@eaguad1337
Copy link
Member Author

removed workaround for not implemented methods in mssql and postgres @josephmancuso

@yubarajshrestha
Copy link
Contributor

@eaguad1337 please fix the linter issues, I believe it's good to have this feature in the framework.

Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmancuso josephmancuso merged commit 0c455d0 into MasoniteFramework:2.0 Dec 6, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants