Refactor Route.py to include a default option for route names

MasoniteFramework · Oct 16, 2024 · 5271c3c · 5271c3c
1 parent 70b4537
commit 5271c3c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/masonite/routes/Route.py b/src/masonite/routes/Route.py
@@ -157,7 +157,7 @@ def group(self, *routes, **options):
                 route.compile_route_to_regex()
 
             if options.get("name"):
-                route._name = options.get("name") + route._name
+                route._name = options.get("name", "") + (route._name or "")
 
             if options.get("domain"):
                 route.domain(options.get("domain"))

diff --git a/tests/routes/test_routes.py b/tests/routes/test_routes.py
@@ -132,12 +132,14 @@ def test_group_naming(self):
             Route.group(
                 Route.get("/group", "WelcomeController@show").name(".index"),
                 Route.post("/login", "WelcomeController@show").name(".index"),
+                Route.post("/login", "WelcomeController@show"),
                 prefix="/testing",
                 name="dashboard",
             )
         )
 
         route = router.find_by_name("dashboard.index")
+        route = router.find_by_name("dashboard")
         self.assertTrue(route)
 
     def test_compile_year(self):