Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cert warnings #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefanIGit
Copy link

Hi, I'm still confused with all this git stuff.
I hope this time I pulled the correct bulkan:master and applied the patch again, now with a little update help.

Here the old commit text:

with this, the parameter verify=${False} (default) will supress self
signed cert errors like below, which works for me :D
But this maybe not the idea behind it in first place.

I still think the logger set up in "if disable_warnings" is wrong it
kills the robot logger settings so you do not see any warnings or debug
messages from my custom libraries any more.

unexpected error:
C:\Python27\lib\site-packages\urllib3\connectionpool.py:852:
InsecureRequestWarning: Unverified HTTPS request is being made. Adding
certificate verification is strongly advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
C:\Python27\lib\site-packages\urllib3\connectionpool.py:852:
InsecureRequestWarning: Unverified HTTPS request is being made. Adding
certificate verification is strongly advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)

Hi, I'm still confused with all this git stuff.
I hope this time I pulled the correct bulkan:master and applied the patch again, now with a little update help.

Here the old commit text:

with this, the parameter verify=${False} (default) will supress self
signed cert errors like below, which works for me :D
But this maybe not the idea behind it in first place.

I still think the logger set up  in "if disable_warnings" is wrong it
kills the robot logger settings so you do not see any warnings or debug
messages from my custom libraries any more.

unexpected error:
C:\Python27\lib\site-packages\urllib3\connectionpool.py:852:
InsecureRequestWarning: Unverified HTTPS request is being made. Adding
certificate verification is strongly advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
C:\Python27\lib\site-packages\urllib3\connectionpool.py:852:
InsecureRequestWarning: Unverified HTTPS request is being made. Adding
certificate verification is strongly advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
InsecureRequestWarning)
Copy link
Contributor

@vkosuri vkosuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hernandik
Copy link

hernandik commented Jan 23, 2023

I'm catch by verify parameter and their documentation.
It is a little misleading. Looking for the documentation, it cite that it can be {True} or {False} and some places it cite it as being {True}, others {False}, and also it can be the PATH for the certificate.

When I set the certificate it works well. When I set it to {True}, warnings on missing certificate stop happening, and no other errors appear related to certificate. When I set it to ${False}, the error keep appearing. I think this is a little confuse. I think we should remove the {True} option from this variable. Either it is {False} or it is PATH. Should I open a bug for this issue?

@lucagiove
Copy link
Member

I'm catch by verify parameter and their documentation. It is a little misleading. Looking for the documentation, it cite that it can be {True} or {False} and some places it cite it as being {True}, others {False}, and also it can be the PATH for the certificate.

Thanks, do you refer to the create session documentation versus get parameters documentation?
I see and you might open a bug, yes please.

@ArditD
Copy link

ArditD commented Apr 19, 2023

Ciao @lucagiove ,
this is indeed needed since GET|POST|DELETE|ETC On Session does not seem to inherit the verify=False from the session itself, so it's generating allot of warnings
./usr/lib/python3.10/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host '172.16.11.4'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings warnings.warn(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

5 participants