Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-35189: Updating cache for INNODB_LOCKS et al is suboptimal #3584

Draft
wants to merge 1 commit into
base: 10.6
Choose a base branch
from

Conversation

dr-m
Copy link
Contributor

@dr-m dr-m commented Oct 17, 2024

  • The Jira issue number for this PR is: MDEV-35189

Description

There are some performance issues with the cache that is underlying the INFORMATION_SCHEMA tables INNODB_LOCKS, INNODB_LOCK_WAITS and INNODB_TRX.

ha_storage_put_memlim(): Invoke my_crc32c() just once to "fold".

fold_lock(): Remove some redundant conditions and use my_crc32c() instead of ut_fold_ulint_pair().

add_lock_to_cache(): Invoke fold_lock() only once.

TODO (MDEV-35190): Combine HASH_SEARCH and HASH_INSERT similar to buf_pool.page_hash.cell_get().

Release Notes

There performance of InnoDB hash table operations was slightly improved.

How can this PR be tested?

./mtr --parallel=auto innodb.innodb_i_s_innodb_trx innodb.innodb_i_s_innodb_locks

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

Some of this would be applicable to 10.5 as well, but we target 10.6 because of the MDEV-35190 dependency.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

ha_storage_put_memlim(): Invoke my_crc32c() just once to "fold".

fold_lock(): Remove some redundant conditions and use my_crc32c()
instead of ut_fold_ulint_pair().

add_lock_to_cache(): Invoke fold_lock() only once.

TODO (MDEV-35190): Combine HASH_SEARCH and HASH_INSERT similar to
buf_pool.page_hash.cell_get(). This should also be done in
dict_sys_t::add() and other places
@dr-m dr-m self-assigned this Oct 17, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants