Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHS language update and bug fixes #85

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

wubinwww
Copy link
Contributor

@wubinwww wubinwww commented Nov 5, 2024

No description provided.

@Manu098vm Manu098vm merged commit 18e5d34 into Manu098vm:main Nov 5, 2024
1 check passed
@Manu098vm
Copy link
Owner

May I ask what bug the following code did made to occur?
return txt is not null ? txt.Split("\r\n") : [];

Removing the "\r" makes all the text lines to be composed with a carriage return. It results in something like this:
immagine
immagine

The old code did work fine for me, even on CHS and CHT languages.
immagine
immagine

I will restore the old code, in the meanwhile if you can make a bug report of what it caused and how to reproduce it, I can search for a proper fix.

@wubinwww
Copy link
Contributor Author

wubinwww commented Nov 6, 2024 via email

@Manu098vm
Copy link
Owner

I can not reproduce that issue. I'm under the impression your system is changing the way translation files/chars are stored.
Can you reproduce the issue with the automatic compiled build from my latest commit?
https://github.com/Manu098vm/Tera-Finder/actions/runs/11708197482

If so, please post a screenshot of how it looks on your PC. This is how the above build works on my end.
immagine
I'm only interested to see if you can reproduce the issue with the automatic build, not with builds that comes from your system, which may have chars coded differently.

@wubinwww
Copy link
Contributor Author

wubinwww commented Nov 6, 2024 via email

@wubinwww
Copy link
Contributor Author

wubinwww commented Nov 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants