feat: update to Node 16 with strict mode

action.yml

@@ -32,7 +32,7 @@ inputs:
     description: 'Path to the Nx workspace, needed if not the repository root'
     required: false
 runs:
-  using: 'node12'
+  using: 'node16'
   main: 'dist/index.js'
 branding:
   icon: 'terminal'

package.json

@@ -1,10 +1,10 @@
 {
   "name": "nrwl-nx-action",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "![Banner](.github/assets/banner-thin.png)",
   "main": "lib/index.js",
   "scripts": {
-    "build": "tsc",
+    "build": "tsc --build ./tsconfig.build.json",
     "lint": "eslint src",
     "lint:fix": "eslint --fix src",
     "prepackage": "npm run build",
@@ -47,6 +47,7 @@
     "@commitlint/cli": "17.1.2",
     "@commitlint/config-conventional": "17.1.0",
     "@octokit/webhooks": "10.3.0",
+    "@tsconfig/node16-strictest": "1.0.4",
     "@typescript-eslint/eslint-plugin": "5.40.1",
     "@typescript-eslint/parser": "5.40.1",
     "@vercel/ncc": "0.34.0",

src/index.ts

@@ -1,7 +1,7 @@
 import * as core from '@actions/core';
 
 import { CommandBuilder } from './command-builder';
-import { Inputs } from './inputs';
+import type { Inputs } from './inputs';
 import { runNx } from './run-nx';
 
 const ARGS_REGEX = /\w+|"(?:\\"|[^"])+"/g;

src/run-nx.ts

@@ -1,11 +1,10 @@
 import * as core from '@actions/core';
 import * as exec from '@actions/exec';
 import * as github from '@actions/github';
-// eslint-disable-next-line import/no-unresolved
-import { PullRequest, PushEvent } from '@octokit/webhooks-types';
+import type { PullRequest, PushEvent } from '@octokit/webhooks-types';
 
-import { CommandWrapper } from './command-builder';
-import { Inputs } from './inputs';
+import type { CommandWrapper } from './command-builder';
+import type { Inputs } from './inputs';
 
 async function retrieveGitBoundaries(): Promise<[base: string, head: string]> {
   if (github.context.eventName === 'pull_request') {
@@ -89,11 +88,11 @@ export async function runNx(inputs: Inputs, nx: CommandWrapper): Promise<void> {
 
   if (inputs.nxCloud) {
     args.push('--scan');
-    process.env.NX_RUN_GROUP = github.context.runId.toString();
+    process.env['NX_RUN_GROUP'] = github.context.runId.toString();
 
     if (github.context.eventName === 'pull_request') {
       const prPayload = github.context.payload.pull_request as PullRequest;
-      process.env.NX_BRANCH = prPayload.number.toString();
+      process.env['NX_BRANCH'] = prPayload.number.toString();
     }
   }
 

tsconfig.build.json

@@ -0,0 +1,5 @@
+{
+  "extends": "./tsconfig.json",
+  "include": [],
+  "files": ["src/index.ts"]
+}

tsconfig.json

@@ -1,12 +1,10 @@
 {
+  "extends": "@tsconfig/node16-strictest/tsconfig.json",
   "compilerOptions": {
-    "target": "es6",
-    "module": "commonjs",
+    "removeComments": true,
     "outDir": "./lib",
-    "rootDir": "./src",
-    "strict": true,
-    "noImplicitAny": true,
-    "esModuleInterop": true
+    "rootDir": "./src"
   },
-  "exclude": ["node_modules", "**/*.spec.ts"]
+  "include": ["**/*.ts"],
+  "exclude": ["dist", "lib"]
 }