Xclbinutil build #12
Closed
Xclbinutil build #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manoj Takasi <[email protected]>
ManojTakasi
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Initial implementation of some HIP memory APIs. (#11) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemset(). (#12) Signed-off-by: Chiming Zhang <[email protected]> * minor fix to hipHostMalloc() (#13) Signed-off-by: Chiming Zhang <[email protected]> * Fix the typo. (#14) Signed-off-by: Chiming Zhang <[email protected]> * fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * fix minor error in error.cpp. Signed-off-by: Chiming Zhang <[email protected]> * remove new operation from memory_database::GetInstance(). Signed-off-by: Chiming Zhang <[email protected]> * Fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * change class name error_state to error. Signed-off-by: Chiming Zhang <[email protected]> * remove some duplicate code. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>
ManojTakasi
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Initial implementation of some HIP memory APIs. (#11) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemset(). (#12) Signed-off-by: Chiming Zhang <[email protected]> * minor fix to hipHostMalloc() (#13) Signed-off-by: Chiming Zhang <[email protected]> * Fix the typo. (#14) Signed-off-by: Chiming Zhang <[email protected]> * fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * fix minor error in error.cpp. Signed-off-by: Chiming Zhang <[email protected]> * remove new operation from memory_database::GetInstance(). Signed-off-by: Chiming Zhang <[email protected]> * Fix some issues from code review. Signed-off-by: Chiming Zhang <[email protected]> * change class name error_state to error. Signed-off-by: Chiming Zhang <[email protected]> * remove some duplicate code. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix some issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * fix more issues. Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#15) Signed-off-by: Chiming Zhang <[email protected]> * Add hipMemcpyHtoDAsync(). (#16) * Add hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * enque copy_buffer command instead of submitting directly. Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]> * Add check for invalid size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * remove free() from hip_memset(). Signed-off-by: Chiming Zhang <[email protected]> * add missing async policy in copy_buffer::submit(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing handling of parameter size in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * Add missing offset in hipMemcpyHtoDAsync(). Signed-off-by: Chiming Zhang <[email protected]> * change return type of memory_database::get_hip_mem_from_addr() Signed-off-by: Chiming Zhang <[email protected]> --------- Signed-off-by: Chiming Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)