Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved consistency of rate_function implementations #4144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved consistency of rate_function implementations #4144

wants to merge 1 commit into from

Conversation

BenKirkels
Copy link

Overview: What does this pull request change?

The following rate function now make use of the unit_interval decorator to handle t < 0 and t > 1:

  • smoothstep
  • smootherstep
  • smoothererstep

Motivation and Explanation: Why and how do your changes improve the library?

This change makes the implementations of all rate functions consistent.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenKirkels