Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented loop counter for "Every" trigger #2

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

AmirAref
Copy link
Contributor

If pass any negative number to parameters of Every trigger, it will go to an infinity loop without any sleep time!
So I think it's better to accept only positive numbers as arguments.

Copy link
Owner

@ManiMozaffar ManiMozaffar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aioclock/types.py Outdated Show resolved Hide resolved
@ManiMozaffar ManiMozaffar changed the title accept only positive numbers on Every() trigger Implemented loop counter for "Every" trigger Apr 12, 2024
@ManiMozaffar ManiMozaffar merged commit 5526133 into ManiMozaffar:main Apr 12, 2024
3 checks passed
@AmirAref AmirAref deleted the positive-number branch October 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants