Improved installer #370

johnnyt · 2015-01-18T06:36:09Z

@mpapis @Monty @timfel - this is finally working.

What do you guys think?

This closes #195

…ed code style

…tion, do not use rake for start

…download

Monty · 2015-01-18T17:39:48Z

Double oops. Drat! I was not looking at the branch johnnyt/improved_installer. Still need to check whether tar xfz works on all platforms.

— Monty

On Jan 18, 2015, at 9:29 AM, Monty Williams [email protected] wrote:

Oops. I was looking at diffs not the final file. This must have been changed back to using gunzip.

On Jan 18, 2015, at 9:16 AM, Monty Williams <[email protected] mailto:[email protected]> wrote:

Thanks to @johnnyt & @mpapis for all the work! Glad to see it’s finally implemented after so many years of waiting.

Has anyone checked on Solaris? In particular does tar xfz work? Maybe it was AIX that caused me to use gunzip -c $gss_file | tar xf -

Cheers,
Monty

On Jan 17, 2015, at 10:36 PM, JohnnyT <[email protected] mailto:[email protected]> wrote:

@mpapis https://github.com/mpapis @Monty https://github.com/Monty @timfel https://github.com/timfel - this is finally working.

What do you guys think?

This closes #195 #195
You can view, comment on, or merge this pull request online at:

#370 #370
Commit Summary

separate valiation and setup steps from install process
proof of concept: allow configuring destination and used paths, cleaned code style
remove root check from setup.sh, it's allowed this time
forward install.sh parameters to update.sh
formating + improve the platform check
allow running stwrappers, restore rake, move copy to the optimal location, do not use rake for start
cleaning and formating setup.sh
translate rake tasks to shell
make sure important steps are executed, fail otherwise
fix Gemstone VM name for download
fix Gemstone VM name for download
make sure all helpers are loaded
changes from @timfel
improve error reporting for build_maglev
allow specifying stonename and make sure it persist for update
improved error reporting for command run in stone
just reordering functions
improve the process, add --help
show last 10 lines of the log on error
fix build_maglev_in_stone finalizing and return status
increase log output to 50 lines in case of errors
improve logging and outputs for build_maglev_in_stone
Fix merge conflicts in update.sh
Uses gemtalksystems.com http://gemtalksystems.com/ for GSS download
Fixes merge conflicts
Changes GemStone versions directory
Changes gss_file to filename only; cd into versions directory before download
🚫 Ignores versions directory
🚫 Ignores RubyGems directory
Runs topaz as a linked session
Changes mkdir_p to mkdir -p
Removes config file args - they are set as ENV vars
Changes STONE_NAME to STONENAME
Fixes outfile assignment
🚫 Ignores .stonename
Fixes MAGLEV_HOME var in loadfiletree.gs
Uses loadfiletree.gs instead of inlining
File Changes

M .gitignore https://github.com/MagLev/maglev/pull/370/files#diff-0 (3)
A build_functions.sh https://github.com/MagLev/maglev/pull/370/files#diff-1 (208)
M install.sh https://github.com/MagLev/maglev/pull/370/files#diff-2 (218)
A setup.sh https://github.com/MagLev/maglev/pull/370/files#diff-3 (178)
M src/smalltalk/loadfiletree.gs https://github.com/MagLev/maglev/pull/370/files#diff-4 (2)
M update.sh https://github.com/MagLev/maglev/pull/370/files#diff-5 (346)
A validate.sh https://github.com/MagLev/maglev/pull/370/files#diff-6 (50)
Patch Links:

https://github.com/MagLev/maglev/pull/370.patch https://github.com/MagLev/maglev/pull/370.patch
https://github.com/MagLev/maglev/pull/370.diff https://github.com/MagLev/maglev/pull/370.diff
—
Reply to this email directly or view it on GitHub #370.

johnnyt · 2015-01-19T14:43:23Z

@Monty @AllenOtis - I couldn't see any builds for Solaris at http://seaside.gemtalksystems.com/maglev/
should there be any listed there?

Monty · 2015-01-19T17:23:50Z

No. Only Mac & Linux. I was thinking of the install script for GemStone/S which also needs Solaris & AIX. MagLev scripts don't actually need to run on those platforms.

I was confused because some of the shell scripts used to be shared.

— Monty

Sent from Mailbox for iPad

On Mon, Jan 19, 2015 at 6:43 AM, JohnnyT [email protected] wrote:

@Monty @AllenOtis - I couldn't see any builds for Solaris at http://seaside.gemtalksystems.com/maglev/

should there be any listed there?

Reply to this email directly or view it on GitHub:
#370 (comment)

johnnyt · 2015-01-22T23:28:43Z

I'd like to get this merged in if we can - @mpapis - what do you think? Have you had any time to try it out / look it over?

mpapis · 2015-01-22T23:30:41Z

no I did not had time to look into it, will try to find time for review but it might get merged sooner - then I will work on integrating the new installer into RVM and review during it

mpapis · 2015-02-15T00:39:36Z

I'm sorry but I probably wont have time to review - please don't wait for me

johnnyt · 2015-02-17T22:47:59Z

@jc00ke - This is finally ready to merge

jc00ke · 2015-02-17T23:40:38Z

I'll take a look now, and if nothing jumps out I'll merge.

jc00ke · 2015-02-17T23:47:36Z

update.sh

-    $cmd http://seaside.gemtalksystems.com/maglev/$gss_file
+builtin cd "${GEMSTONES_HOME}"
+if
+  [[ -e $gss_file ]]


Should quote $gss_file here like on line 183.

Fixed in 7b98855

jc00ke · 2015-02-17T23:56:32Z

Thoughts on log_info, log_warn and log_error functions that will add some color to the output?

johnnyt · 2015-03-15T20:48:35Z

Colored logging would be nice - I just created issue #376 for that.

@jc00ke how does this look? I'd love to get this merged in so we can get working on the parser.

Improved installer

jc00ke · 2015-03-16T14:52:25Z

Cool, let's get to that parser!

mpapis and others added 30 commits December 12, 2012 15:43

separate valiation and setup steps from install process

cbd533c

proof of concept: allow configuring destination and used paths, clean…

3aa475c

…ed code style

remove root check from setup.sh, it's allowed this time

2979c68

forward install.sh parameters to update.sh

8effb8f

formating + improve the platform check

86c98b8

allow running stwrappers, restore rake, move copy to the optimal loca…

b2a8e4b

…tion, do not use rake for start

cleaning and formating setup.sh

c926531

translate rake tasks to shell

53d92c6

make sure important steps are executed, fail otherwise

64eb87e

fix Gemstone VM name for download

d96c560

fix Gemstone VM name for download

90f68bb

make sure all helpers are loaded

4a3283f

changes from @timfel

d2d6292

improve error reporting for build_maglev

6b0461b

allow specifying stonename and make sure it persist for update

8225d05

improved error reporting for command run in stone

2c2f820

just reordering functions

2332b7e

improve the process, add --help

c00b17c

show last 10 lines of the log on error

f097685

fix build_maglev_in_stone finalizing and return status

d96f208

increase log output to 50 lines in case of errors

871150f

improve logging and outputs for build_maglev_in_stone

374509b

Fix merge conflicts in update.sh

1cb63e8

Uses gemtalksystems.com for GSS download

f977d7c

Fixes merge conflicts

7f813d0

Changes GemStone versions directory

cefdc42

Changes gss_file to filename only; cd into versions directory before …

8331152

…download

🚫 Ignores versions directory

c816bc7

🚫 Ignores RubyGems directory

c8ca1ca

Runs topaz as a linked session

4c8235b

johnnyt added 2 commits February 17, 2015 11:08

Updates missing rake warning message

66df8d5

Changes INFO to Info

8fda9da

johnnyt mentioned this pull request Feb 17, 2015

Add build and install of libmagparse.so to the build.rake #352

Closed

johnnyt added 2 commits February 17, 2015 15:55

Fixes merge conflicts

20c4fd2

Fixes indentation in TravisCI config

bb64665

jc00ke reviewed Feb 17, 2015
View reviewed changes

johnnyt added 3 commits February 20, 2015 13:53

Quotes gss_file

7b98855

Adds space for redirection

1ff4375

Errors and exits if unable to build new ruby extent

a305067

This was referenced Mar 15, 2015

Add utils.sh for common code in setup.sh and validate.sh #375

Open

Unified logging for setup.sh, update.sh #376

Open

jc00ke added a commit that referenced this pull request Mar 16, 2015

Merge pull request #370 from MagLev/johnnyt/improved_installer

5297560

Improved installer

jc00ke merged commit 5297560 into master Mar 16, 2015

jc00ke deleted the johnnyt/improved_installer branch March 16, 2015 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved installer #370

Improved installer #370

johnnyt commented Jan 18, 2015

Monty commented Jan 18, 2015

johnnyt commented Jan 19, 2015

Monty commented Jan 19, 2015

should there be any listed there?

johnnyt commented Jan 22, 2015

mpapis commented Jan 22, 2015

mpapis commented Feb 15, 2015

johnnyt commented Feb 17, 2015

jc00ke commented Feb 17, 2015

jc00ke Feb 17, 2015

johnnyt Feb 25, 2015

jc00ke commented Feb 17, 2015

johnnyt commented Mar 15, 2015

jc00ke commented Mar 16, 2015

Improved installer #370

Improved installer #370

Conversation

johnnyt commented Jan 18, 2015

Monty commented Jan 18, 2015

johnnyt commented Jan 19, 2015

Monty commented Jan 19, 2015

should there be any listed there?

johnnyt commented Jan 22, 2015

mpapis commented Jan 22, 2015

mpapis commented Feb 15, 2015

johnnyt commented Feb 17, 2015

jc00ke commented Feb 17, 2015

jc00ke Feb 17, 2015

Choose a reason for hiding this comment

johnnyt Feb 25, 2015

Choose a reason for hiding this comment

jc00ke commented Feb 17, 2015

johnnyt commented Mar 15, 2015

jc00ke commented Mar 16, 2015