Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonhydro documentation #526

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix nonhydro documentation #526

merged 1 commit into from
Feb 8, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 8, 2023

This merge also includes a fix to the Chicoma docs

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working documentation Improvements or additions to documentation labels Feb 8, 2023
@xylar xylar requested review from scalandr and cbegeman February 8, 2023 17:30
@xylar xylar self-assigned this Feb 8, 2023
@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2023

Testing

I built the docs locally and (after fixing an indentation issue in the API) everything looks good now.

This merge also includes a fix to the Chicoma docs
@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2023

@cbegeman and @scalandr, I think we were all a bit exhausted in #374 and a few glitches in the documentation crept in at the end. This is to fix those (because they're making it hard to have correct documentation in other PRs).

Please take a glance at my fixes and make sure there's nothing obviously wrong. No need to build locally or anything.

Please approve today or tomorrow if you can because I want to rebase #525 onto this fix.

Copy link
Collaborator

@scalandr scalandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Xylar, I looked at your changes and could not see anything obviously wrong, so I approved the request.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Thanks for this fix! Approving based on visual inspection.

@xylar
Copy link
Collaborator Author

xylar commented Feb 8, 2023

Thank you @scalandr and @cbegeman for responding so promptly! This is very helpful.

@xylar xylar merged commit d9c3eae into MPAS-Dev:main Feb 8, 2023
@xylar xylar deleted the fix_docs branch February 8, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants