Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend MMDB with max_country_info_qt #697

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Extend MMDB with max_country_info_qt #697

merged 2 commits into from
Oct 29, 2024

Conversation

cudeso
Copy link
Contributor

@cudeso cudeso commented Oct 18, 2024

When querying MMDB there are sometimes multiple country_info objects returned, mostly due to the different db_source. Sometimes customers are not interested in the db_source, and only the geo-info. This change adds max_country_qt. When

  • Set to None or 0, has no effect
  • Set to a value higher than 0, the number of country_info entries is limited to max_country_info_qt

When querying MMDB there are sometimes multiple country_info objects returned, mostly due to the different db_source. Sometimes customers are not interested in the db_source, and only the geo-info.
This change adds max_country_qt. When
- Set to None or 0, has no effect
- Set to a value higher than 0, the number of country_info entries is limited to max_country_qt
@cudeso cudeso changed the title Extend MMDB with max_country_qt Extend MMDB with max_country_info_qt Oct 18, 2024
@adulau adulau merged commit 1a2c7f0 into MISP:main Oct 29, 2024
5 of 6 checks passed
@adulau
Copy link
Member

adulau commented Oct 29, 2024

Thanks a lot for update to the module. I just updated the moduleinfo to align with the new metadata format of each module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants