Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Vysion #678

Merged
merged 16 commits into from
Aug 9, 2024
Merged

Re-add Vysion #678

merged 16 commits into from
Aug 9, 2024

Conversation

German7463
Copy link
Contributor

Hello MISP team!

We have seen that the Vysion module was removed due to incompatibilities. In this new version, we have updated the dependencies and the version of pymisp used by our client to adapt the module to latest versions. We have been able to verify that it now works correctly with the latest version of our library and different Python versions.

In addition, new types of inputs have been included for the enrichment module, now you can also search by XMR and DASH cryptocurrencies. And we have updated the names of the misp-objects "vysion-page" and "vysion-ransomware-feed" to the Dark-web taxonomy (https://www.circl.lu/doc/misp-taxonomies/#_dark_web), available in our public repository (https://github.com/ByronLabs/vysion-cti/tree/main/misp).

If you have any comments or questions, please do not hesitate to contact us.

Thanks and best regards,

Germán Esteban.

@adulau
Copy link
Member

adulau commented Aug 9, 2024

Thanks for working on this.

A small question, we cannot access the source code of the repository for the Python package https://gitlab.com/byronlabs/vysion/vysion-py which is mentioned in the pypi repo. Is this normal?

@German7463
Copy link
Contributor Author

Hello,

We just updated the information on PyPi, thanks for the warning, we migrated the repository to GitHub and didn't include it. The current repository is: https://github.com/ByronLabs/vysion-py

We also wanted to ask you about the Python version checks, we have seen that sometimes they work and sometimes they don't work. In our fork all 5 checks work, but we had to do a re-run failed jobs. Has it happened in other PRs?
image2

Just with the last MISP:main sync it passed all 5 checks, but it could be a coincidence.

@ostefano
Copy link
Collaborator

ostefano commented Aug 9, 2024

LGTM 👍

@adulau adulau merged commit e0d44bd into MISP:main Aug 9, 2024
5 checks passed
@adulau
Copy link
Member

adulau commented Aug 9, 2024

Great! Thanks a lot for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants