Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: [internal] Add support for orjson #648

Merged
merged 12 commits into from
Jan 8, 2024
Merged

Conversation

JakubOnderka
Copy link
Contributor

@JakubOnderka JakubOnderka commented Jan 6, 2024

orjson is optional dependency, that will make parsing and serializing JSON faster.

@adulau
Copy link
Member

adulau commented Jan 6, 2024

Question: why do you replace the sys.exit by return ? It’s kind of intended to use an exit or _exit to ensure the program quit.

@adulau
Copy link
Member

adulau commented Jan 6, 2024

Another question, I like the idea of the healthcheck but why not using the introspection directly?

@JakubOnderka JakubOnderka changed the title chg: [internal] Code style chg: [internal] Add support for orjson Jan 8, 2024
@JakubOnderka
Copy link
Contributor Author

Question: why do you replace the sys.exit by return ? It’s kind of intended to use an exit or _exit to ensure the program quit.

It will be the same with return.

Another question, I like the idea of the healthcheck but why not using the introspection directly?

You mean /modules request? I think /healthcheck is cleaner way, usually this call is made every 30 seconds inside container, so /modules just consumes CPU for nothing.

@JakubOnderka JakubOnderka marked this pull request as ready for review January 8, 2024 13:29
@JakubOnderka JakubOnderka merged commit 9dc3fbe into MISP:main Jan 8, 2024
4 checks passed
@JakubOnderka JakubOnderka deleted the orjson branch January 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants