Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[threat-actors] Adding 10 actors #887

Merged
merged 11 commits into from
Nov 4, 2023
Merged

[threat-actors] Adding 10 actors #887

merged 11 commits into from
Nov 4, 2023

Conversation

Mathieu4141
Copy link
Contributor

No description provided.

@Mathieu4141 Mathieu4141 force-pushed the threat-actors/04da55b3-acda-4e77-b687-e7f9329d0fd1 branch from e2622c6 to 025345e Compare November 3, 2023 19:09
@Mathieu4141
Copy link
Contributor Author

Looks like the deduplication tests are done with the version of the file that is on master?

@cvandeplas
Copy link
Member

Deduplication tests are indeed done by PyMISPGalaxies, which is not run by validate_all.sh, but run in the unit testing (see .travis.yml). These are indeed run whenever you push to the PR, but I think it is not triggered when you force push.

Thank you for the contribution!

@cvandeplas cvandeplas merged commit 6192258 into MISP:main Nov 4, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mathieu4141 @cvandeplas