update malpedia galaxy #877
Conversation
| @@ -13,7 +13,7 @@ | |||
| "name": "Malpedia", | |||
| "source": "Malpedia", | |||
| "type": "malpedia", | |||
| "uuid": "1d1c9af9-37fa-4deb-a928-f9b0abc7354a", | |||
There was a problem hiding this comment.
Not sure why you changed the UUID, it should remain fixed.
There was a problem hiding this comment.
hm Curious .. this came automaticly from the fetch_malpedia.sh script
There was a problem hiding this comment.
if i look right, the uuid come from Malpedia itself
https://malpedia.caad.fkie.fraunhofer.de/api/get/misp
There was a problem hiding this comment.
@danielplohmann maybe we should keep the UUID of the cluster from the malpedia api. What do you think?
There was a problem hiding this comment.
I just had a look at our code base, the generated galaxy accessible from our API endpoint should always come with UUID 5fc98d08-90a4-498a-ad2e-0edf50ef374e (git blame says, at least since 2018-10-10) for consistency reasons, only the content and version field changes in accordance with our internal commit count.
There was a problem hiding this comment.
Ok, so that means @danielplohmann that 5fc98d08-90a4-498a-ad2e-0edf50ef374e are the correct UUID ?
There was a problem hiding this comment.
@danielplohmann It should be the current one in the misp repository. If not it will be see as a new malpedia galaxy. Could you use the current one? Thank you
There was a problem hiding this comment.
Yeah, no problem, we will change it on our server to match the UUID that you already have!
Should be deployed in the next days with an upcoming update we are preparing anyway. 👍
There was a problem hiding this comment.
for completeness, we finally deployed a big update yesterday which should also fix the UUID issue that was raised here.
|
Thanks for the contribution. I merged it with the updated UUID. |
No description provided.