-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fix and performance Improvements #12
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "earcut" | ||
version = "0.4.0" | ||
version = "0.4.1" | ||
edition = "2021" | ||
description = "A Rust port of the Earcut polygon triangulation library" | ||
authors = ["Taku Fukada <[email protected]>", "MIERUNE Inc. <[email protected]>"] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -20,19 +20,19 @@ A Rust port of the [mapbox/earcut](https://github.com/mapbox/earcut) polygon tri | |||||
|
||||||
on Macbook Pro (M1 Pro) | ||||||
|
||||||
| Polygon | earcut.hpp | earcut-rs (0.4.0) | earcutr (0.4.3) | | ||||||
|----------------|-------------:|--------------:|-------------:| | ||||||
| bad_hole | 3.574 µs/i | 4.630 µs/i | 4.415 µs/i | | ||||||
| building | 397 ns/i | 197 ns/i | 604 ns/i | | ||||||
| degenerate | 142 ns/i | 46 ns/i | 206 ns/i | | ||||||
| dude | 5.061 µs/i | 6.516 µs/i | 8.096 µs/i | | ||||||
| empty_square | 195 ns/i | 88 ns/i | 331 ns/i | | ||||||
| water | 459.6 µs/i | 623.5 µs/i | 801.3 µs/i | | ||||||
| water2 | 334.1 µs/i | 409.5 µs/i | 450.3 µs/i | | ||||||
| water3 | 13.12 µs/i | 19.12 µs/i | 23.46 µs/i | | ||||||
| water3b | 1.340 µs/i | 1.368 µs/i | 2.165 µs/i | | ||||||
| water4 | 81.48 µs/i | 122.0 µs/i | 154.1 µs/i | | ||||||
| water_huge | 6.906 ms/i | 11.01 ms/i | 10.90 ms/i | | ||||||
| water_huge2 | 15.38 ms/i | 23.40 ms/i | 22.35 ms/i | | ||||||
| Polygon | earcut.hpp | earcut-rs (0.4.1) | earcutr (0.4.3) | | ||||||
|---------------|-------------:|------------------:|----------------:| | ||||||
| bad_hole | 3.574 µs/i | 4.623 µs/i | 4.415 µs/i | | ||||||
| building | 397 ns/i | 195 ns/i | 604 ns/i | | ||||||
| degenerate | 142 ns/i | 45 ns/i | 206 ns/i | | ||||||
| dude | 5.061 µs/i | 6.496 µs/i | 8.096 µs/i | | ||||||
| empty_square | 195 ns/i | 74 ns/i | 331 ns/i | | ||||||
| water | 459.6 µs/i | 574.5 µs/i | 801.3 µs/i | | ||||||
| water2 | 334.1 µs/i | 393.9 µs/i | 450.3 µs/i | | ||||||
| water3 | 13.12 µs/i | 19.21 µs/i | 23.46 µs/i | | ||||||
| water3b | 1.340 µs/i | 1.345 µs/i | 2.165 µs/i | | ||||||
| water4 | 81.48 µs/i | 110.6 µs/i | 154.1 µs/i | | ||||||
| water_huge | 6.906 ms/i | 11.0k ms/i | 10.90 ms/i | | ||||||
| water_huge2 | 15.38 ms/i | 23.60 ms/i | 22.35 ms/i | | ||||||
|
||||||
(Earcutr is not besed on the latest earcut.) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the spelling error in the note about - (Earcutr is not besed on the latest earcut.)
+ (Earcutr is not based on the latest earcut.) Committable suggestion
Suggested change
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing spaces to clean up the document formatting.
Committable suggestion