Lint: Utils module #350
Lint: Utils module #350
Conversation
| hash_params, | ||
| cache_dir, | ||
| cache_content={"data": None, "metadata": None, "write_json": write_json}, | ||
| clear_cache_file=clear_cache, |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| handle_caching( | ||
| hash_params, | ||
| cache_dir, | ||
| cache_content={"data": data, "metadata": None, "write_json": None}, | ||
| clear_cache_file=clear_cache, | ||
| ) |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| handle_caching( | ||
| self.hash_params, | ||
| self.cache_dir, | ||
| cache_content={"data": self.data, "metadata": None, "write_json": None}, | ||
| ) |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| handle_caching( | ||
| self.hash_params, | ||
| self.cache_dir, | ||
| cache_content={"data": self.data, "metadata": None, "write_json": None}, | ||
| ) | ||
|
|
||
| retrieved_data, _, _ = handle_caching( | ||
| self.hash_params, | ||
| self.cache_dir, | ||
| cache_content={"data": None, "metadata": None, "write_json": None}, | ||
| ) | ||
|
|
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| handle_caching( | ||
| self.hash_params, | ||
| cache_dir, | ||
| cache_content={"data": self.data, "metadata": None, "write_json": None}, | ||
| ) |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| handle_caching( | ||
| hash_params, | ||
| cache_dir, | ||
| cache_content={"data": data, "metadata": meta, "write_json": None}, | ||
| ) |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| data, _, _ = handle_caching( | ||
| hash_params, | ||
| cache_dir, | ||
| cache_content={"data": None, "metadata": None, "write_json": None}, | ||
| clear_cache_file=clear_cache, | ||
| ) |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| hash_params, | ||
| cache_dir, | ||
| cache_content={"data": None, "metadata": None, "write_json": None}, | ||
| clear_cache_file=clear_cache, |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| hash_params, | ||
| cache_dir, | ||
| cache_content={ | ||
| "data": ndbc_data[buoy_id][year], | ||
| "metadata": None, | ||
| "write_json": None, | ||
| }, |
There was a problem hiding this comment.
handle_caching reduced to only 5 inputs
https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#max-args
| - name: Run Pylint on mhkit/utils/ | ||
| run: | | ||
| pylint mhkit/utils/ |
There was a problem hiding this comment.
Add utils module to the linting enforcement
Modifies MHKiT to make the
utilsmodule PyLint compatible and enforces compatibility via GitHub Actions.Additionally this PR modifies the GitHub Actions testing environment to use the conda environment.yml file.