Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional dolfyn functionality #102

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Commits on Mar 1, 2023

  1. Configuration menu
    Copy the full SHA
    fa3baae View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. More clean functions added

    -fillgaps_depth and val_exceeds_thresh added to clean folder
    -formatting changes for fillgaps_time for consistency
    -remove numpy from nan_beyond_surface to fix error
    -notice that fillgaps_time and fillgaps_depth do the same thing, need to change to interpolate over just time/depth respectively
    zur-quin committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e0f1857 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Update fillgaps_time and fillgaps_depth

    -update these functions to interpolate over time and depth respectively
    -using fillmissing function in matlab now to specify an interpolation dimension
    -include maxgap option for both above functions
    -update comments for above functions
    zur-quin committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2cd4004 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Add minimalistic worksheet to use new functions

    New worksheet to demo val_exceeds_thresh and fill_gaps_time functions.
    Calls the same functions/uses same file for testing as python tests for these functions.
    zur-quin committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    6939b7a View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Update fillgaps_time

    -fillgaps_time now checks var's type a little, and also uses correct error syntax
    -Note: MATLAB's fillmissing function does not have a default option for MaxGap, so if statement is still used for MaxGap argument
    zur-quin committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ffd4b59 View commit details
    Browse the repository at this point in the history
  2. Update fillgaps_depth

    -update fillgaps_depth function to cover discussed changes. now checking if var is from dolfyn structure, using better syntax for throwing errors
    -Note: fillmissing function doesn't offer default value for MaxGap in documentation, if statement needed to call correct function from fillgaps_depth
    zur-quin committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c980a41 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Update val_exceeds_thresh error syntax

    -val_exceeds_thresh now checks types and throws an error if structure passed to function is not from dolfyn
    zur-quin committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b4d6495 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Add proper Test file for functions

    Add tests/Dolfyn_Test_Clean.m to mimic test_clean.py from python version of MHKiT. Currently compares cleaned data to itself in order to pass tests. Next step: Move cleaned data files into repo to compare with tests here.
    zur-quin committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6b3adfd View commit details
    Browse the repository at this point in the history
  2. Remove test_clean_adcp_example.mlx

    Since actual test file added, test_clean_adcp_example.mlx not needed
    zur-quin committed May 2, 2023
    Configuration menu
    Copy the full SHA
    001e4d4 View commit details
    Browse the repository at this point in the history
  3. Update test clean with tests for future clean functions

    Dolfyn_Test_Clean.m updated to have functions for future tests.
    Dolfyn_Test_Clean.m now has all same tests as test_clean.py
    Commented out sections for "TODO" component/future clean functions to be added
    zur-quin committed May 2, 2023
    Configuration menu
    Copy the full SHA
    08ec7f4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Add clean data in test_data subdirectory

    move required cleaned data from python version to test_data folder
    start using cleaned data to compare in the tests (instead of comparing to self)
    zur-quin committed May 3, 2023
    Configuration menu
    Copy the full SHA
    581f044 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Configuration menu
    Copy the full SHA
    7a8f751 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Fix x* vs x_star fieldname from read_netcdf.m

    There was a bug in read_netcd.m where it wasn't reading from the fixed field x_star, and was trying to read the nonexistant x* field.
    zur-quin committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d5c6b2c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. WIP add find_surface function

    Add find_surface function, not quite finished still has a few errors from translating from python.
    zur-quin committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    bbac4c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update comments with TODO notes

    Cleaned up these files with additional comments and clarifications on items.
    zur-quin committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f052b98 View commit details
    Browse the repository at this point in the history