Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ! ------ #486

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Removal of ! ------ #486

merged 3 commits into from
Jun 23, 2024

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented Jun 23, 2024

Description

Removes all ! ----- as mentioned here #483

Type of change

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

  • Github Actions
  • Local of my Machine

Test Configuration:

Ubuntu 22.04.4 LTS, gcc14
Github Actions

Checklist

  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran an Omniperf profile using ./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

@okBrian okBrian requested a review from sbryngelson as a code owner June 23, 2024 20:42
@sbryngelson sbryngelson merged commit fc85a76 into MFlowCode:master Jun 23, 2024
19 checks passed
@okBrian okBrian deleted the removal branch June 24, 2024 17:02
AiredaleDev pushed a commit to AiredaleDev/MFC that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants