-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try switching themes #61
Conversation
|
|
docs/source/_static/custom.css
Outdated
body { | ||
font-family: 'PT Sans', Helvetica, Arial, 'sans-serif'; | ||
font-size: 17px; | ||
.dataTables_wrapper.no-footer .wy-table-responsive { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This from seems to do the trick in making sure the table isn't horribly squashed: readthedocs/sphinx_rtd_theme#1287 (comment)
I suspect this isn't something we'd want to upstream since we don't really use dataTables anywhere else in the ecosystem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I reckon we should upstream this! It's unlikely it'd affect anything else and if we do want to use datatables in the future, I assume we'd want to apply the same styling. Also it seems like a pity to keep this file just for this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as a commit for now -- of course I can revert if you disagree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, let's see if that does the trick.
Alright, thanks @lilyminium, I think this all works? I'll avoid merging this until you give us the thumbs up that it's good to go ahead (probably post merge of https://github.com/MDAnalysis/mdanalysis-sphinx-theme/compare/update-theme). |
Thanks @IAlibay! It LGTM but I agree it's a good idea to wait until https://github.com/MDAnalysis/mdanalysis-sphinx-theme/compare/update-theme is in -- I'll make a new release at that point too, so we can avoid pinning to development branches :D I'll check how the docs look on some other core repos first but otherwise I think we're pretty close, the mdakit and smaller repos have less complicated docs so shouldn't require too many theme updates. |
Thanks for all the work here @lilyminium - sorry I can't be more useful, it is something I would have loved to spend more time getting to grips with. |
Works great! |
Sorry I didn't want to steal work, I just wanted to try this out a bit and get a feel for how it worked.
In this PR: