Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zarrtraj metadata test dependencies #211

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix zarrtraj metadata test dependencies #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b02094a
fix test dependencies
IAlibay Oct 13, 2024
d60fa2a
fix typo
IAlibay Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gh-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
python-stable: ${{ steps.get-compatible-python.outputs.stable-python }}
python-min: ${{ steps.get-compatible-python.outputs.oldest-pythons }}
python-min: ${{ steps.get-compatible-python.outputs.oldest-python }}
steps:
- uses: actions/setup-python@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion mdakits/zarrtraj/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ run_tests:
## The default below _might_ be sufficient or you might not even need MDAnalysisTests:
## make sure that it is appropriate for how you run tests.
test_dependencies:
- mamba env update --file https://raw.githubusercontent.com/Becksteinlab/zarrtraj/main/devtools/conda-envs/test_env.yaml --name test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orbeckst since you were the approving reviewer on this, just an FYI - this type of hack will break the registry. It effectively overwrite the base mamba environment so you end up with a conda environment without the base mdakit dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks, good to know — can you add a note to https://mdakits.mdanalysis.org/reviewersguide.html please ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a draft entry, please review/edit #212 .

- mamba install "moto[server]>=5.0.3"

## str: the organisation name the MDAKit falls under
project_org: Becksteinlab
Expand Down
Loading