Add support for multiple system accounts #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
reviewed
Feb 19, 2021
| try { | ||
| TryGetToken(accountInfo, tokenBase64); | ||
| } | ||
| catch (...) { |
There was a problem hiding this comment.
I don't like this. I'd be happier if it caught something specific.
Moreover, it shouldn't just silently swallow an error if one occurs.
There was a problem hiding this comment.
I'm no expert at C++ so wouldn't know the best way of doing that, could you implement it?
rtm516
force-pushed
the
fix-multi-accounts
branch
from
769d69c
to
0d21a19
Compare
|
Is this still being worked on? We have something similar for our launcher and I was considering adding the functionality to this repo. |
|
It's no longer necessary with the advent of preview builds so it may end up being redundant. |
I've been using the modified version for ages now with no issues, even modified it further and used it for other projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues when you have more than 1 account on a machine. This now loops all known accounts if the previous doesn't have access to download Minecraft.
I have attached the updated exe and dll below
MCLauncher.zip