Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useAirtableCMS hook updates #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

useAirtableCMS hook updates #124

wants to merge 2 commits into from

Conversation

anaximander
Copy link
Contributor

Removed useAirtableCMS and useLocalStorage hooks (they're now available through @mapc/airtable-cms).

Created a CMSComponent which can be used in place of the useAirtableCMS hook, and provides basic error handling, empty state, and loading state.

Updated existing components to make use of new CMSComponent.

@@ -80,7 +80,6 @@
h4 {
@extend ._vertical-center;

top: 30%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what this change is for

Copy link
Contributor

@navneetjoshi223 navneetjoshi223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: Just observed there seems to be a conflict in TrackingProgress.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants