Hotfix for Zoning Atlas Data #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomtay
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Both links work for me on the Zoning dataset, so this seems like a reasonable workaround for now. It'll break if we change the name of the table, but I doubt we're in imminent danger of that. I'd just take out the console.log on line 72 and then ready to merge!
| @@ -67,13 +67,20 @@ function downloadCsv( | |||
| queryYearColumn = '' | |||
| ) { | |||
| const yearString = selectedYears.join(); | |||
| if (table === 'zoning_atlas') { | |||
| return 'https://mapc365.sharepoint.com/:x:/s/DataServicesSP/Efonrnmw_kdMhmG3Dw2BkTcBIpe2sC_2ADWTWfUjOs4JhQ?e=K65BCE'; | |||
| console.log('Hello Matt!'); | |||
There was a problem hiding this comment.
This didn't trigger for me since it's after the return, but probably good to take out just for code cleanliness.
* Because the Zoning Atlas data did not properly display for users who chose to use Excel as their CSV viewer, we are now providing a Sharepoint link that is in XLSX format for their conveinence. * Even more annoying was that the shapefile did not include any shapes when we exported it. So we also had to create the shapefile manually and put into sharefile. Related to #366 and #365, but does not fix them beyond Zoning Atlas.
mzagaja
force-pushed
the
mjz/temporary-csv-shapefile-links-for-za
branch
from
78e7119
to
dcbf856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #366 and #365, but does not fix them beyond Zoning Atlas.