refactor: project layout improvements #201
reviewdog [golangci-lint-github-check] report
reported by reviewdog 🐶
Findings (7)
pkg/packer/packer.go|16 col 10| interface method Prepare must have all named params (inamedparam)
pkg/packer/packer.go|17 col 8| interface method Build must have named param for type string (inamedparam)
pkg/packer/packer.go|18 col 10| interface method Install must have named param for type string (inamedparam)
pkg/packer/packer.go|19 col 21| interface method PrepareEnvironment must have named param for type bool (inamedparam)
pkg/source/source.go|232 col 12| fmt.Sprintf can be replaced with faster hex.EncodeToString (perfsprint)
pkg/project/project_test.go|63 col 2| require-error: for error assertions use require (testifylint)
pkg/project/project_test.go|114 col 2| require-error: for error assertions use require (testifylint)
Filtered Findings (0)
Annotations
Check failure on line 16 in pkg/packer/packer.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/packer/packer.go#L16
interface method Prepare must have all named params (inamedparam)
Raw output
pkg/packer/packer.go:16:10: interface method Prepare must have all named params (inamedparam)
Prepare([]string) error
^
Check failure on line 17 in pkg/packer/packer.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/packer/packer.go#L17
interface method Build must have named param for type string (inamedparam)
Raw output
pkg/packer/packer.go:17:8: interface method Build must have named param for type string (inamedparam)
Build(string) error
^
Check failure on line 18 in pkg/packer/packer.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/packer/packer.go#L18
interface method Install must have named param for type string (inamedparam)
Raw output
pkg/packer/packer.go:18:10: interface method Install must have named param for type string (inamedparam)
Install(string) error
^
Check failure on line 19 in pkg/packer/packer.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/packer/packer.go#L19
interface method PrepareEnvironment must have named param for type bool (inamedparam)
Raw output
pkg/packer/packer.go:19:21: interface method PrepareEnvironment must have named param for type bool (inamedparam)
PrepareEnvironment(bool) error
^
Check failure on line 232 in pkg/source/source.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/source/source.go#L232
fmt.Sprintf can be replaced with faster hex.EncodeToString (perfsprint)
Raw output
pkg/source/source.go:232:12: fmt.Sprintf can be replaced with faster hex.EncodeToString (perfsprint)
hexSum := fmt.Sprintf("%x", sum)
^
Check failure on line 63 in pkg/project/project_test.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/project/project_test.go#L63
require-error: for error assertions use require (testifylint)
Raw output
pkg/project/project_test.go:63:2: require-error: for error assertions use require (testifylint)
assert.NoError(t, os.WriteFile(packageRaw, []byte(`{
^
Check failure on line 114 in pkg/project/project_test.go
github-actions / golangci-lint-github-check
[golangci-lint-github-check] pkg/project/project_test.go#L114
require-error: for error assertions use require (testifylint)
Raw output
pkg/project/project_test.go:114:2: require-error: for error assertions use require (testifylint)
assert.NoError(t, err)
^